Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ckanext-spatial #4

Open
wants to merge 49 commits into
base: link-oeh-master
Choose a base branch
from

Conversation

wildcatzita
Copy link

No description provided.

David Read and others added 30 commits October 9, 2015 15:37
…WAF harvester that currently uses it, and that is only basic use.
[#2470] Allow newer requests versions.
Set the L.TileLayer as a TMS. It's required if the base layer specified in custom.url is a TMS. The default value of tms is false in Leaflet.
To use the TMS option, ```ckanext.spatial.common_map.tms = true``` has to be set in the ckan .INI file.

Same as ckan/ckanext-geoview#24
Fixed typo.
Because plugins are loaded for every paster command, regardless of which
paster command is being run, when lots of plugins are installed startup
time can be substantial.

To fix this, making sure that plugin.py in various extensions doesn't
import unnecessary (and potentially slow) modules, this PR moves the
imports of some function into the function where they are called.

This reduces paster startup time (for me) by up to .5 seconds, which
while not significant by itself, contributes to my current 8 second
startup time.
remove legacy CSW server implementation
Add info about "how to configure tms"

ckan#129
update docs, remove code not used
Speed up non-spatial paster commands.
Set tms option for custom layer
Copy link

@MrkGrgsn MrkGrgsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are about 20 upstream commits missing, everything after 1 June 2016. Also there is a regression with the import, see my other comment

from ckan.lib.helpers import json

import shapely.geometry
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this import is required. It was moved to before_index() in an upstream commit.

@MrkGrgsn
Copy link

MrkGrgsn commented Jan 4, 2017

Also, the merge commit message is ambiguous about whether it contained any feature updates. I would use a message like 'Merge upstream master into link-oeh-master'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants