Dish intern #208
Open
Dish intern #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedi-of-the-sea
requested review from
warm-coolguy and
dopenguin
as code owners
dopenguin
requested changes
Dec 17, 2024
packages/clients/dish/CHANGELOG.md
Outdated
| @@ -3,6 +3,10 @@ | |||
| ## unpublished | |||
|
|
|||
| - Feature: If a user is geolocated outside of the map's extent, the client will inform the user of why geolocation did not take effect via a textbox. | |||
| - Feature: The map can now be used for internal use with specific configurations. This will be defined by the parameter `MODE` in the index.html. The parameters `internalHost`, `internalPort` and `internalPath` for the internal map must be passed in the `createMap` call. | |||
| - Feature: New searches for address and parcels added. | |||
There was a problem hiding this comment.
Suggested change
| - Feature: New searches for address and parcels added. | |
| - Feature: Add new searches for addresses and parcels. |
packages/clients/dish/CHANGELOG.md
Outdated
| @@ -3,6 +3,10 @@ | |||
| ## unpublished | |||
|
|
|||
| - Feature: If a user is geolocated outside of the map's extent, the client will inform the user of why geolocation did not take effect via a textbox. | |||
| - Feature: The map can now be used for internal use with specific configurations. This will be defined by the parameter `MODE` in the index.html. The parameters `internalHost`, `internalPort` and `internalPath` for the internal map must be passed in the `createMap` call. | |||
| - Feature: New searches for address and parcels added. | |||
| - Feature: New background and specialist data layers added. | |||
There was a problem hiding this comment.
Suggested change
| - Feature: New background and specialist data layers added. | |
| - Feature: Add new background and specialist data layers. |
packages/clients/dish/CHANGELOG.md
Outdated
| - Feature: The map can now be used for internal use with specific configurations. This will be defined by the parameter `MODE` in the index.html. The parameters `internalHost`, `internalPort` and `internalPath` for the internal map must be passed in the `createMap` call. | ||
| - Feature: New searches for address and parcels added. | ||
| - Feature: New background and specialist data layers added. | ||
| - Feature: New plugins DishExportMap and InternGfi for intern mode use added. |
There was a problem hiding this comment.
Suggested change
| - Feature: New plugins DishExportMap and InternGfi for intern mode use added. | |
| - Feature: Add new plugins DishExportMap and InternGfi for usage in the internal mode. |
packages/clients/dish/README.md
Outdated
| @@ -2,14 +2,30 @@ | |||
|
|
|||
| ## Content | |||
|
|
|||
| The client can use two different configurations which are controlled by the parameter `MODE`. `MODE="EXTERN"` will apply the configuration for the map client as the website for the public, and `MODE="INTERN"` for the map used in the internal DISH application. `MODE` is initially set and cannot be changed after hosting. | |||
packages/clients/dish/README.md
Outdated
Comment on lines
29
to
31
|
|
||
|
|
||
|
|
Comment on lines
+27
to
+29
| interne Benutzerhinweise | ||
| </v-card-text> | ||
| <v-card-text> interne Benutzerhinweise </v-card-text> |
There was a problem hiding this comment.
Is interne Benutzerhinweise currently a placeholder?
There was a problem hiding this comment.
yes, I am currently waiting for the content that should be displayed there.
| export default Vue.extend({ | ||
| name: 'DishModalHints', | ||
| computed: { | ||
| ...getSetGenerator('plugin/modal', ['closed']), |
There was a problem hiding this comment.
@warm-coolguy do you remember the reason why the mutation setClosed is not being used here (as this is the same in Hint.vue)?
Comment on lines
+52
to
+59
| maxFeatures() { | ||
| const search = this.selectedGroup.find( | ||
| (searchService) => | ||
| searchService.categoryId === 'categoryDenkmalsucheDish' | ||
| ) | ||
| if (search) return search.queryParameters.maxFeatures | ||
| return '' | ||
| }, |
There was a problem hiding this comment.
Suggested change
| maxFeatures() { | |
| const search = this.selectedGroup.find( | |
| (searchService) => | |
| searchService.categoryId === 'categoryDenkmalsucheDish' | |
| ) | |
| if (search) return search.queryParameters.maxFeatures | |
| return '' | |
| }, |
This is not being used.
There was a problem hiding this comment.
GeoJsonProperties from import { GeoJsonProperties } from 'geojson' is the correct type for currentProperties as windowFeatures is typed as GeoJsonProperties[] and currentProperties is typed as GeoJsonProperties.
| import { FeatureCollection, Geometry, GeometryCollection } from 'geojson' | ||
|
|
||
| export function zoomToFeatureById( | ||
| instance, |
There was a problem hiding this comment.
Please expose MapInstance of @polar/core as described by this ADR as a new export and use it as a type here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
DISH client with two modes for different usage.
The mode INTERN uses a new plugins DishExportMap and a new custom gfi component InternGfi.
Both modes got two new search configurations for address search and parcel search.
New background layers were added to the EXTERN map client.
Instructions for local reproduction and review
Start the client and set
modein the index.html to EXTERN and INTERN for different views.Note that some services in INTERN Mode are not availaible as they have a specific intranet URL and we do not have access to that. Also, some services in INTERN are only available in VPN.