Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: <caption> breaking keyboard table navigation #374

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

BGruenberg
Copy link
Collaborator

Navigation ist wichtiger als eine Überschrift.

Könnte an NVDA liegen. @tjorbo Hast du Voiceover und kannst das einmal prüfen?
Das Thema existiert auch kaum, ich hab nur diesen Kommentar gefunden.

@BGruenberg BGruenberg requested review from tjorbo and hassmal December 17, 2024 09:27
@tjorbo
Copy link
Member

tjorbo commented Dec 18, 2024

@BGruenberg

Ich kann durch die Tabelle navigieren.

Bildschirmfoto 2024-12-18 um 11 07 43 Bildschirmfoto 2024-12-18 um 11 08 06 Bildschirmfoto 2024-12-18 um 11 08 47

@tjorbo tjorbo removed their request for review December 18, 2024 10:11
@BGruenberg BGruenberg marked this pull request as ready for review December 18, 2024 12:03
A usable navigation is more important than a caption.
@BGruenberg BGruenberg force-pushed the fix/table-accessibility branch from e9bff77 to 99efe65 Compare December 18, 2024 12:04
@tjorbo tjorbo self-requested a review December 19, 2024 09:15
Copy link
Member

@tjorbo tjorbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Danke 🍀

@BGruenberg BGruenberg merged commit 7552ca0 into main Dec 19, 2024
5 checks passed
@BGruenberg BGruenberg deleted the fix/table-accessibility branch December 19, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants