Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clarify Compatibility Check Message Update check_compatibility.sh #134

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

0xbryer
Copy link

@0xbryer 0xbryer commented Dec 13, 2024

Describe your changes

This update addresses a minor issue in the compatibility check script where the final message was slightly misleading. Previously, if some requirements were not compatible, the script outputted:

echo -e "${RED}All requirements are NOT compatible with Python $python_version.${NC}"

This has been corrected to:

echo -e "${RED}Some requirements are NOT compatible with Python $python_version.${NC}"

The revised message more accurately reflects the situation, as the check only determines that some requirements are incompatible, not all.

Additionally, the logic and functionality of the script remain unchanged. This is a purely textual fix to improve clarity for users reviewing compatibility results.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I wrote tests.
  • Need to take care of performance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant