Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to sign additional headers in request #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

avoidik
Copy link

@avoidik avoidik commented Jan 17, 2019

This change will allow you to sign additional headers in request

Linked issue #38

@BlaiseGratton
Copy link

Any intentions to get this merged in? Currently needing precisely this functionality.

@DavidMuller
Copy link
Owner

Not planning on merging this one as the use case seems to involve non AWS services.

@avoidik
Copy link
Author

avoidik commented Jan 13, 2020

This use-case covers optional headers to sign mentioned at
https://docs.aws.amazon.com/general/latest/gr/sigv4-signed-request-examples.html

# Note: The request can include any headers; canonical_headers and
# signed_headers lists those that you want to be included in the 
# hash of the request. "Host" and "x-amz-date" are always required.

@avoidik
Copy link
Author

avoidik commented Jul 9, 2020

still no? :)

@rezen
Copy link

rezen commented Oct 26, 2020

@DavidMuller I'm confused by the statement - "use case seems to involve non AWS services"? AWS signed requests can only be used by AWS?

@avoidik
Copy link
Author

avoidik commented May 23, 2021

@avoidik
Copy link
Author

avoidik commented Jul 27, 2023

Hey hey, stumbled upon yet another header for otel and then immediately recalled this PR. Still no? :)

@rezen
Copy link

rezen commented Jul 27, 2023

@avoidik you can create a request using AWSRequest from botocore. You can probably pull from the first python code snippet to make a request

https://ahermosilla.com/cloud/2020/11/17/leveraging-aws-signed-requests.html#use-botocore-to-create-client

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants