Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctmod: Remove D8VK #422

Merged
merged 2 commits into from
Jul 10, 2024
Merged

ctmod: Remove D8VK #422

merged 2 commits into from
Jul 10, 2024

Conversation

sonic2kk
Copy link
Contributor

@sonic2kk sonic2kk commented Jul 8, 2024

D8VK has now, at long last, been merged into DXVK (doitsujin/dxvk#3411, D8VK readme)! There is no need for us to offer D8VK anymore, as DXVK Nightly will cover the basis here. We hooked into D8VK CI anyway because at the time there were no releases, and we never added the stable releases. Plus, there hadn't been any commits in so long since it was waiting on upstream DXVK to review and merge, so all CI artifacts had expired anyway...

I updated the DXVK ctmod descriptions to note that it supports Direct3D 8, 9, 10, and 11 so that anyone looking for D8VK and was not aware of the change should hopefully see that description change and know that DXVK now supports Direct3D 8. We can also note on the changelog for the next release that D8VK is now available upstream.

Note: The description update is technically only accurate for DXVK Nightly right now. Support for Direct3D 8 is not yet in a release at time of writing, although I imagine there will be a release very soon. And the DXVK Async patch gets updated whenever there is a new release of DXVK, so it'll be updated afterwards too. Personally I think it's fine to be a little "ahead" here in the interest of helping users migrate from D8VK to DXVK,, instead of being under the impression that D8VK was removed, but I am happy to change it if you think this is too misleading :-)

Thanks!

@DavidoTek
Copy link
Owner

Thanks, that was a fast PR!

D8VK has now, at long last, been merged into DXVK

I read the news on sunday and was excited!

I updated the DXVK ctmod descriptions to note that it supports Direct3D 8, 9, 10, and 11 so that anyone looking for D8VK and was not aware of the change should hopefully see that description change and know that DXVK now supports Direct3D 8. We can also note on the changelog for the next release that D8VK is now available upstream.

Great. Yes, we should include a note in the changelog.

Note: The description update is technically only accurate for DXVK Nightly right now. Support for Direct3D 8 is not yet in a release at time of writing, although I imagine there will be a release very soon

I think it makes sense to include this once there is a new release out. I've added a reminder to my calender in 5 days to check if there will be a release of DXVK then. It's probably also time for a new ProtonUp-Qt release soon 😄


@DavidoTek PR is ready to merge once a new version of DXVK has been released: https://github.com/doitsujin/dxvk/releases

@sonic2kk
Copy link
Contributor Author

sonic2kk commented Jul 9, 2024

I've added a reminder to my calender in 5 days to check if there will be a release of DXVK then

I will also keep an eye out. I think it's fine to wait for a new DXVK release. I don't know if we need to wait on a new DXVK Async release, but I imagine Async is much less important for Direct3D 8 😉

It's probably also time for a new ProtonUp-Qt release soon 😄

Heh, that would be great 😄 But! Maybe we should wait to see the progress on #415 ? It's not our bug, but if it's merged upstream, we can bump our dependency version and have it fixed without needing to do a hotfix-release.

@DavidoTek DavidoTek merged commit 887702a into DavidoTek:main Jul 10, 2024
@sonic2kk
Copy link
Contributor Author

They made that release faster than I expected 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants