NorthStar Proton: Simplify by inheriting GE-Proton Ctmod #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows us to specify the archive format for tools that subclass GE-Proton. Could be replaced in future with a specific check that then chooses which extract util function to use.
sonic2kk
changed the title
|
I wonder if instead of specifying |
DavidoTek
reviewed
Mar 3, 2025
| @@ -159,7 +161,7 @@ def get_tool(self, version, install_dir, temp_dir): | |||
| if source_checksum and (download_checksum not in source_checksum): | |||
| return False | |||
|
|
|||
| if not extract_tar(proton_tar, install_dir, mode='gz'): | |||
| if not extract_tar(proton_tar, install_dir, mode=self.release_format.split('.')[-1]): | |||
There was a problem hiding this comment.
This may need some modifications in case we get more compatibility tools that use .zip like Proton-Tkg or some other non-tar archive.
We can change that once we inherit a tool that needs it.
I think the |
This was referenced Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the NorthStar Proton Ctmod by subclassing the GE-Proton ctmod, removing a lot of overlapping code.
As part of some cleanup to achieve this, the GE-Proton Ctmod was refactored slightly to hold a
release_format. NorthStar Proton and GE-Proton both use.tar.gzformats, but in future I hope to allow more Ctmods to inherit from GE-Proton. Since I was here I figured it would be good housekeeping to implement it now that we have a couple of Ctmods taking from GE-Proton :-)I tested both GE-Proton and NorthStar Proton and they should still be downloading correctly.
Let me know if there are any concerns with this, or if I have missed something. Thanks!