Proton-CachyOS: Remove deprecated Type Hinting #499
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the deprecated type hints from the
typing
module. They exist sprinkled throughout the codebase, and should be removed, so I don't mean to single out this ctmod. I spotted this as I'm eyeing some changes to help it further inherit from the GE-Proton ctmod in the future, so I was in and around here and noticed it. I have also removed a couple of unused imports from this Ctmod.I also added the
@override
annotation to methods we override from GE-Proton, which we currently don't do elsewhere in the codebase, although it is something I also did in #498. Like with removing the old deprecated type hints, I hope to go through and add these around the codebase where relevant (I think only the Ctmods, maybe there's a Qt component we subclass for the Shortcut Editor but I'm not 100% sure).