Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep delivery - First pass fix linter #56

Merged
merged 5 commits into from
Nov 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .env
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# ODM product version
ODMVERSION=9.0.0.0
ODMIMAGEVERSION=9.0.0.0
ODMVERSION=9.0.0.1
ODMIMAGEVERSION=9.0.0.1
# Directory name of the odm-ondocker checkout
ODMDOCKERDIR=docker

Expand All @@ -11,4 +11,4 @@ REPOSITORY=ibmcom
PREFIXIMAGE=odm

# Liberty Version
FROMLIBERTY=ibmcom/websphere-liberty:24.0.0.3-kernel-java17-openj9-ubi
FROMLIBERTY=ibmcom/websphere-liberty:24.0.0.9-kernel-java17-openj9-ubi
10 changes: 5 additions & 5 deletions .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@ name: Build and test
on: [push]
env:
DOCKER_COMPOSE_VERSION: 1.29.2
FROMLIBERTY: ibmcom/websphere-liberty:24.0.0.3-kernel-java11-openj9-ubi
FROMLIBERTY: ibmcom/websphere-liberty:24.0.0.9-kernel-java11-openj9-ubi
HELM_VERSION: 3.6.2
ODM_VERSION: 9.0.0.0
ODM_VERSION: 9.0.0.1
ODMDOCKERDIR: docker
ODMIMAGEVERSION: 8.12.0.1
ODMVERSION: 8.12.0.1-amd64
ODMIMAGEVERSION: 9.0.0.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est pas 9.0.0.1 ?

ODMVERSION: 9.0.0.1-amd64
PREFIXIMAGE: odm

jobs:
Expand All @@ -32,7 +32,7 @@ jobs:
run: tar zxfv helm.tar.gz && chmod 755 cv docker-compose linux-amd64/helm hey && sudo mv cv docker-compose linux-amd64/helm hey /usr/local/bin/
- run: docker-compose --version
- run: helm version
- run: cv lint helm charts/ibm-odm-metering -o charts/ibm-odm-metering/tests/lintOverride.yaml
- run: cv lint helm charts/ibm-odm-metering -o charts/ibm-odm-metering/tests/lintOverride.yaml --set license=accept
- run: bash download-odm.sh
env:
ARTIFACTORY_PASSWORD: ${{ secrets.ARTIFACTORY_PASSWORD }}
Expand Down
16 changes: 11 additions & 5 deletions charts/ibm-odm-metering/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,8 +1,13 @@
apiVersion: v1
apiVersion: v2
description: IBM Operational Decision Manager metering service
name: ibm-odm-metering
version: 24.1.0
appVersion: 9.0.0.1
description: |-
IBM Operational Decision Manager for Developers

License
By installing this product you accept the following license terms: https://www14.software.ibm.com/cgi-bin/weblap/lap.pl?li_formnum=L-RBPW-WQTC4A
home: https://www.ibm.com/docs/en/odm/9.0.0
icon: https://raw.githubusercontent.com/ODMDev/ruledesigner/master/icons/automation-decision.png
sources:
Expand All @@ -11,12 +16,13 @@ keywords:
- OperationalDecisionManager
- businessrules
- Limited
- ICP
- RHOCP
- ROKS
- amd64
- s390x
- ppc64le
- ICPRHOCP
- Middleware
maintainers:
- name: ODMDev
tillerVersion: ">=2.9.1"
kubeVersion: ">= 1.24.0-0"
- name: IBM
kubeVersion: ">= 1.25.0-0"
4 changes: 2 additions & 2 deletions charts/ibm-odm-metering/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -343,11 +343,11 @@ readOnlyRootFilesystem: false
requiredDropCapabilities:
- ALL
runAsUser:
type: MustRunAsNonRoot
type: MustRunAsRange
seccompProfiles:
- docker/default
seLinuxContext:
type: RunAsAny
type: MustRunAs
supplementalGroups:
type: MustRunAs
ranges:
Expand Down
1 change: 1 addition & 0 deletions charts/ibm-odm-metering/templates/tests/test-pattern.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ metadata:
{{ include "odm-additional-labels" . | indent 4 }}
annotations:
helm.sh/hook: test-success
productMetric: "FREE"
spec:
{{ include "odm-serviceAccountName" . | indent 2 }}
hostNetwork: false
Expand Down
6 changes: 5 additions & 1 deletion charts/ibm-odm-metering/tests/lintOverride.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,8 @@ overrides:
- rule: ReadmeHasRequiredSections
reason: "Prefer to have cutomization section than configuration."
- rule: NoReadWriteMany
reason: "Needs to work on it. Too late for the 22.0.1 Release."
reason: "Needs to work on it. Too late for the 22.0.1 Release."
- rule: NoReadWriteMany
reason: "Needs to work on it. Too late for the 22.0.1 Release."
- rule: ContainerLivenessOverLongInitialDelaySeconds
reason: "Metering service take time to start"
2 changes: 1 addition & 1 deletion charts/ibm-odm-metering/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ license: ""
# Declare variables to be passed into your templates.
image:
repository: "icr.io/cpopen/odm-k8s"
tag: 9.0.0.0
tag: 9.0.0.1
pullPolicy: IfNotPresent
## Optionally specify an array of imagePullSecrets.
## Secrets must be manually created in the namespace.
Expand Down
1 change: 1 addition & 0 deletions download-cv.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ set -ex

GH_API=https://github.ibm.com/api/v3
GH_REPO=${GH_API}/repos/IBMPrivateCloud/content-verification
# GH_LATEST=${GH_REPO}/releases/tags/v4.8.1
GH_LATEST=${GH_REPO}/releases/tags/v2.7.0
AUTH="Authorization: token ${GHE_TOKEN}"

Expand Down
Loading