Simplify docker build. Just docker build .
#78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some differences: * No dependencies besides docker required, including java, maven, etc. (Nice for CI) * Use docker layer cache to avoid downloading dependencies every build * Redownload all dependencies based on when pom.xml is changed Also substitute deprecated "MAINTAINER" step in favor of "LABEL".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some differences:
Also substitute deprecated "MAINTAINER" step in favor of "LABEL".
Flattened the docker directory into the repo root since it isn't being used the same way anymore.
Also simplified the Makefile since it doesn't have to do as much.
The docker build itself seems to complete without issue, but that's obviously not the same as testing it live. So I'm not sure if the resulting image works the same. If I determine that I will post with my results.
I'm very open to feedback and would be happy to discuss my motivations for these changes and make adjustments to better fit the desired direction of the project. Thank you for zkui!