Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column Mock improvements #37

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Column Mock improvements #37

merged 2 commits into from
Jan 16, 2024

Conversation

mcnick
Copy link
Collaborator

@mcnick mcnick commented Jan 14, 2024

What problem does this PR solve

The PR contains multiple small improvements to the usability of Column Mocks

What changed

  • made column mock nullable by default
  • array inner types use other column mocks
  • added BigQuery column mocks

Checklist

  • I added tests for new functionality if applicable
  • I added an entry for changes to the unreleased changes of CHANGELOG.md
  • I added documentation for new functionality if applicable
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes

* array inner types use other mock columns
* added BigQuery mock columns
@mcnick mcnick requested a review from Somtom January 14, 2024 15:17
@mcnick mcnick self-assigned this Jan 14, 2024
Copy link
Collaborator

@Somtom Somtom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some minor things. Thanks for tackling that.

@mcnick mcnick requested a review from Somtom January 15, 2024 07:22
@mcnick mcnick merged commit 52c9dc3 into v6-release Jan 16, 2024
@mcnick mcnick deleted the column-mock-improvements branch January 16, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants