Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support secure connection to Clickhouse #40

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Conversation

Somtom
Copy link
Collaborator

@Somtom Somtom commented Jan 24, 2024

What problem does this PR solve

Our Clickhouse integration currently doesn't support secure connections

What changed

  • Use clickhouse_connect library now to support secure connections
  • Added a new environment variable

Checklist

  • I added tests for new functionality if applicable
  • I added an entry for changes to the unreleased changes of CHANGELOG.md
  • I added documentation for new functionality if applicable
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes

@Somtom Somtom self-assigned this Jan 24, 2024
@Somtom Somtom merged commit 409b05c into main Jan 24, 2024
3 checks passed
@Somtom Somtom deleted the support-secure-ch-connections branch January 24, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant