Test library execution against Clickhouse engine #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoothml
force-pushed
the
clickhouse-test-environment
branch
from
23de1bd to
f99c2e5
Compare
smoothml
changed the title
Somtom
reviewed
Apr 10, 2024
There has been a couple of recent issues in which test execution failed in certain scenarios (#48 and #53). These weren't caught by the libraries test as it would require executing actual tests against actual SQL queries. This commit will add a framework for running these tests against a running database engine (Clickhouse in the first instance) to better enable these kinds of bugs to be caught.
smoothml
force-pushed
the
clickhouse-test-environment
branch
from
f99c2e5 to
16ec1f2
Compare
Somtom
approved these changes
Apr 12, 2024
smoothml
added a commit
that referenced
this pull request
Apr 16, 2024
This commits will extend the `Makefile` introduced in #54 to include a `lint` command and the `test-package.yml` GitHub actions template updated to make use of the `make` commands. Additionally, linting will be applied to the codebase.
Merged
smoothml
added a commit
that referenced
this pull request
Apr 17, 2024
This commits will extend the `Makefile` introduced in #54 to include a `lint` command and the `test-package.yml` GitHub actions template updated to make use of the `make` commands. Additionally, linting will be applied to the codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been a couple of recent issues in which test execution failed in certain scenarios (#48 and #53). These weren't caught by the libraries test as it would require executing actual tests against actual SQL queries. This commit will add a framework for running these tests against a running database engine (Clickhouse in the first instance) to better enable these kinds of bugs to be caught.