Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary print statement leading to test failures #56

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Remove unnecessary print statement leading to test failures #56

merged 1 commit into from
Apr 17, 2024

Conversation

smoothml
Copy link
Contributor

Closes #53

@smoothml smoothml requested review from fgarzadeleon and Somtom April 16, 2024 11:13
@smoothml smoothml self-assigned this Apr 16, 2024
fgarzadeleon
fgarzadeleon approved these changes Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@fgarzadeleon fgarzadeleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smoothml smoothml merged commit 799dca4 into main Apr 17, 2024
3 checks passed
@smoothml smoothml deleted the 53-fix-clickhouse-argmaxif-bug branch April 17, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Somtom Somtom Somtom approved these changes

@fgarzadeleon fgarzadeleon fgarzadeleon approved these changes

Assignees

@smoothml smoothml

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v0.6.1 Can't parse Clickhouse argMaxIf function
3 participants
@smoothml @fgarzadeleon @Somtom