-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm-local_settings): Add option to add local_settings.py #10803
base: dev
Are you sure you want to change the base?
Conversation
DryRun Security SummaryThe pull request focuses on improving the deployment and configuration of the DefectDojo application in a Kubernetes environment by introducing customizable local settings, enhancing security practices for handling sensitive information, and providing more flexibility in volume mounting and external dependency management. Expand for full summarySummary: The code changes in this pull request are focused on improving the deployment and configuration of the DefectDojo application, a vulnerability management and security tool, in a Kubernetes environment. The key changes include:
From an application security perspective, the changes are generally positive, as they focus on improving the deployment configuration and handling of sensitive information. However, there are a few areas that require careful review and consideration:
Overall, the code changes in this pull request appear to be a step in the right direction for improving the security and maintainability of the DefectDojo application in a Kubernetes environment. However, continuous vigilance and a strong focus on application security best practices are essential to ensure the ongoing security and integrity of the application. Files Changed:
Code AnalysisWe ran |
cea7b4e
to
5018921
Compare
5018921
to
9978908
Compare
9978908
to
96ea735
Compare
96ea735
to
1397f77
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
1397f77
to
90fdaf1
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
90fdaf1
to
be27458
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
@kiblik Sorry, this one fell off my radar. |
This PR adds the ability to use
local_settings.py
in k8s setup as well