Questionnaires: Correct nested object deletions

[Maffooch]

When using questionnaires, deleting an an engagement/product/product-type will result In the following errors:
Engagement

[14/Feb/2024 13:56:06] INFO [django.request:241] OK: /engagement/256/delete
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/django/db/backends/base/base.py", line 306, in _commit
    return self.connection.commit()
           ^^^^^^^^^^^^^^^^^^^^^^^^
psycopg2.errors.ForeignKeyViolation: update or delete on table "dojo_answer" violates foreign key constraint "dojo_choiceanswer_answer_ptr_id_e9da2254_fk_dojo_answer_id" on table "dojo_choiceanswer"
DETAIL:  Key (id)=(62) is still referenced from table "dojo_choiceanswer".

Product/ProductType

[16/Feb/2024 17:59:23] ERROR [django.request:241] Internal Server Error: /product/1/delete
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/django/core/handlers/exception.py", line 56, in inner
    response = get_response(request)
               ^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/django/core/handlers/base.py", line 197, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/dojo/authorization/authorization_decorators.py", line 35, in _wrapped
    return func(request, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/dojo/product/views.py", line 979, in delete_product
    collector.collect([product])
  File "/usr/local/lib/python3.11/site-packages/django/contrib/admin/utils.py", line 186, in collect
    return super().collect(objs, source_attr=source_attr, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/django/db/models/deletion.py", line 345, in collect
    field.remote_field.on_delete(self, field, sub_objs, self.using)
  File "/usr/local/lib/python3.11/site-packages/django/db/models/deletion.py", line 23, in CASCADE
    collector.collect(
  File "/usr/local/lib/python3.11/site-packages/django/contrib/admin/utils.py", line 186, in collect
    return super().collect(objs, source_attr=source_attr, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/django/db/models/deletion.py", line 345, in collect
    field.remote_field.on_delete(self, field, sub_objs, self.using)
  File "/usr/local/lib/python3.11/site-packages/django/db/models/deletion.py", line 23, in CASCADE
    collector.collect(
  File "/usr/local/lib/python3.11/site-packages/django/contrib/admin/utils.py", line 186, in collect
    return super().collect(objs, source_attr=source_attr, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/django/db/models/deletion.py", line 345, in collect
    field.remote_field.on_delete(self, field, sub_objs, self.using)
  File "/usr/local/lib/python3.11/site-packages/django/db/models/deletion.py", line 23, in CASCADE
    collector.collect(
  File "/usr/local/lib/python3.11/site-packages/django/contrib/admin/utils.py", line 186, in collect
    return super().collect(objs, source_attr=source_attr, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/django/db/models/deletion.py", line 323, in collect
    sub_objs = self.related_objects(related_model, [field], batch)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/django/contrib/admin/utils.py", line 193, in related_objects
    qs = super().related_objects(related_model, related_fields, objs)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/django/db/models/deletion.py", line 406, in related_objects
    return related_model._base_manager.using(self.using).filter(predicate)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/django/db/models/query.py", line 1421, in filter
    return self._filter_or_exclude(False, args, kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/django/db/models/query.py", line 1439, in _filter_or_exclude
    clone._filter_or_exclude_inplace(negate, args, kwargs)
  File "/usr/local/lib/python3.11/site-packages/django/db/models/query.py", line 1446, in _filter_or_exclude_inplace
    self._query.add_q(Q(*args, **kwargs))
  File "/usr/local/lib/python3.11/site-packages/django/db/models/sql/query.py", line 1532, in add_q
    clause, _ = self._add_q(q_object, self.used_aliases)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/django/db/models/sql/query.py", line 1562, in _add_q
    child_clause, needed_inner = self.build_filter(
                                 ^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/django/db/models/sql/query.py", line 1388, in build_filter
    return self._add_q(
           ^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/django/db/models/sql/query.py", line 1562, in _add_q
    child_clause, needed_inner = self.build_filter(
                                 ^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/django/db/models/sql/query.py", line 1445, in build_filter
    self.check_related_objects(join_info.final_field, value, join_info.opts)
  File "/usr/local/lib/python3.11/site-packages/django/db/models/sql/query.py", line 1259, in check_related_objects
    self.check_query_object_type(v, opts, field)
  File "/usr/local/lib/python3.11/site-packages/django/db/models/sql/query.py", line 1233, in check_query_object_type
    raise ValueError(
ValueError: Cannot query "a": Must be "ChoiceAnswer" instance.

The reason for this error is the django does not support polymorphism out of the box. When determining the nested structure of an object tree, django will make some incorrect assumptions, and attempt to delete a parent object without deleting the children first. To solve this, we can tell django to use the default object manager instead of the polymorphic object manager. Along with some other accommodations that are handled in this PR, a consequence is that there is not a warning in the logs expressing that this behavior is not correct. I have not been able to suppress these warnings:

/app/dojo/models.py:4343: ManagerInheritanceWarning: PolymorphicModel: "Question.objects" manager is of type "Manager", but must be a subclass of PolymorphicManager. to support retrieving subclasses
  class Question(PolymorphicModel, TimeStampedModel):
/app/dojo/models.py:4474: ManagerInheritanceWarning: PolymorphicModel: "Answer.objects" manager is of type "Manager", but must be a subclass of PolymorphicManager. to support retrieving subclasses
  class Answer(PolymorphicModel, TimeStampedModel):
[17/Feb/2024 02:17:15] INFO [dojo.models:4513] enabling audit logging
/app/dojo/models.py:4343: ManagerInheritanceWarning: PolymorphicModel: "Question.objects" manager is of type "Manager", but must be a subclass of PolymorphicManager. to support retrieving subclasses
  class Question(PolymorphicModel, TimeStampedModel):
/app/dojo/models.py:4474: ManagerInheritanceWarning: PolymorphicModel: "Answer.objects" manager is of type "Manager", but must be a subclass of PolymorphicManager. to support retrieving subclasses
  class Answer(PolymorphicModel, TimeStampedModel):

Ref: jazzband/django-polymorphic#229

[sc-4265]

[dryrunsecurity]

Contextual Security Analysis

As DryRun Security performs checks, we’ll summarize them here. You can always dive into the detailed results in the section below for checks.

Status	DryRun Security Check
✅	Sensitive Functions Analyzer
✅	Configured Sensitive Files Analyzer
✅	Sensitive Files Analyzer

Chat with your AI-powered Security Buddy by typing @dryrunsecurity followed by your question into a comment.
Example: @dryrunsecurity What are common security issues with web application cookies?

Install and configure more repositories at DryRun Security

[mtesauro]

Approved