Updated Readme with sample configurations , Added Tests and also fixed some more issues. #29
Conversation
…ted the Readme for sample configuration
|
Hi Martin, |
|
Hi Martin can you please help in approving the PR. |
|
Sorry for the delay. I think it’s fine to merge except:
|
|
Hi Martin, |
|
Hi, The branch won't merge now because it needs rebaselining. Will add some other comments inline in the PR. Martin |
|
|
||
| # Defect density Segregated by Sprints | ||
|
|
||
| Following are the configuraitons for creating defect report charts by Sprint. |
There was a problem hiding this comment.
"configuraitons" is mis-spelled (here and in a few other places)
| Defects by priority chart: defects-by-priority.png | ||
| Defects by priority chart title: Defects by priority | ||
| Defects by type chart: defects-by-type.png | ||
| Defects by type chart title: Defects by type | ||
| Defects by environment chart: defects-by-environment.png | ||
| Defects by environment chart title: Defects by environment | ||
|
|
||
| #provide {} which would capture the team names provided in the configuration. |
There was a problem hiding this comment.
I don't understand what this comment means
There was a problem hiding this comment.
I will fix that with correct sample configuration.
| # Get the fields | ||
| fixversion_field = self.settings['defects_fixversion_field'] | ||
| fixversion_field_id = self.query_manager.field_name_to_id(fixversion_field) if fixversion_field else None | ||
| # Get the fields |
There was a problem hiding this comment.
Why is this comment duplicated?
| @@ -77,120 +90,198 @@ def run(self): | |||
|
|
|||
| def write(self): | |||
| chart_data = self.get_result() | |||
| # fixversion_field_choice = self.settings['defects_fixversion_label'] | |||
| # print(fixversion_field_choice) | |||
There was a problem hiding this comment.
Please don't leave dead code commented out - remove if not needed
| if self.settings['defects_by_priority_chart']: | ||
| self.write_defects_by_priority_chart(chart_data, self.settings['defects_by_priority_chart']) | ||
|
|
||
| self.write_defects_by_priority_chart(chart_data, self.settings['defects_by_priority_chart'],x_label) |
There was a problem hiding this comment.
There should be a space after the comma (several more examples of this below)
|
|
||
| set_chart_style() | ||
| # set_chart_style() |
| window = self.settings['defects_window'] | ||
| type_values = self.settings['defects_type_values'] | ||
|
|
||
| if x_label !='Month': |
There was a problem hiding this comment.
Same point as above re comparator
There was a problem hiding this comment.
config is initialised in config.py as below
'defects_fixversion_label': 'Month',
So if it is overridden then only the Sprint level charting code will be executed.
|
|
||
| labels = [d.strftime("%b %y") for d in breakdown.index] | ||
| ax.set_xticklabels(labels, rotation=90, size='small') | ||
| if x_label =='Month': |
There was a problem hiding this comment.
I will initialise it with a boolean in the start so that it can be used across.
|
|
||
| set_chart_style() | ||
| # set_chart_style() |
| breakdown = breakdown_by_month(chart_data, 'created', 'resolved', 'key', 'environment', environment_values) | ||
|
|
||
|
|
||
| if x_label !='Month': |
There was a problem hiding this comment.
I will initialize it with a boolean in the start so that it can be used across.
Hi Martin,
As per your suggestion I have updated documentation with sample configurations , Added Tests and also fixed some more issues.
Manish