implemented ability to pass on meshkernel parameters from hydrolib #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d removed geometry checks for clipping.
…rs in hydrolib-core are now identical to meshkernel defaults (they were different).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended refinement functions to allow passing of meshkernel parameters and removed checks for clipping (functionality they say is not implemented does in fact work).
In the process the default values that were hardcoded in hydrolib core were changed to the same values as are used in meshkernel (they make more sense), hense the asserts in the refinement test failed, as the number of cells changed slightly. They test has been updated.