feat: external forcing converter cli (unst-8490) #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MAfarrag
changed the base branch from
main
to
feature/unst-8490-tim-to-bc-boundary-condition
… '59e4c72914f9f8abb63ea8c955e6f4e1cfcf8197' of github.com:Deltares/HYDROLIB-core into feature/unst-8490-ext-forcing-converter-cli
…ub.com:Deltares/HYDROLIB-core into feature/unst-8490-ext-forcing-converter-cli
arthurvd
requested changes
Feb 25, 2025
| from pathlib import Path | ||
|
|
||
| from hydrolib.core import __version__ | ||
| from hydrolib.tools.ext_old_to_new.main_converter import ( |
There was a problem hiding this comment.
As discussed: let's have one and the same name for both the tools/ subdirectory "ext_old_to_main" and the new one you introduced in pyproject.toml: "extforce-convert" <-- let's use your name everywhere.
Comment on lines
+65
to
+77
| backup_group.add_argument( | ||
| "--backup", | ||
| "-b", | ||
| action="store_true", | ||
| default=True, | ||
| help="Create a backup of each file that will be overwritten.", | ||
| ) | ||
| backup_group.add_argument( | ||
| "--no-backup", | ||
| dest="backup", | ||
| action="store_false", | ||
| help="Do not create a backup of each file that will be overwritten.", | ||
| ) |
There was a problem hiding this comment.
I just found that argparse allows you to do this with one single call:
class argparse.BooleanOptionalAction
(But check whether the help docs work out well for both the --backup and --no-backup option.)
…ub.com:Deltares/HYDROLIB-core into feature/unst-8490-ext-forcing-converter-cli
…feature/unst-8490-tim-to-bc-boundary-condition' of github.com:Deltares/HYDROLIB-core into feature/unst-8490-ext-forcing-converter-cli
…com:Deltares/HYDROLIB-core into feature/unst-8490-ext-forcing-converter-cli
…ub.com:Deltares/HYDROLIB-core into feature/unst-8490-ext-forcing-converter-cli
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solve
ExtforceFilefield does not exist in the mdu file #754