Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/blog tags #755

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Hotfix/blog tags #755

merged 1 commit into from
Oct 20, 2023

Conversation

VirginiaDooley
Copy link
Contributor

@VirginiaDooley VirginiaDooley commented Oct 18, 2023

Closes #734, #750, #711

https://stage.democracyclub.org.uk/blog/

This work also:

  • Adds featured posts to the home page context (although not currently used on the home page)
  • Renders a menu of blog tags from published posts on the blog post list page so the user can choose and filter
  • Includes misc text changes

To test:

  1. Alt text for blog header images #734: Add alt text to a hero image in the admin panel. Then navigate to the blog and check the source code of the hero image to confirm presence of the same alt text.
  2. Blog tag editing #750 I've added instructions to do this on README.md.
  3. Blog slug issue 🐌 #711 Create a new blog and add the title. A slug should be auto generated from the title.

Screenshot 2023-10-18 at 4 51 55 PM

Screenshot 2023-10-19 at 9 19 52 AM


@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aa92655) 79.08% compared to head (0e945e7) 79.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #755      +/-   ##
==========================================
+ Coverage   79.08%   79.71%   +0.63%     
==========================================
  Files          27       27              
  Lines         545      562      +17     
==========================================
+ Hits          431      448      +17     
  Misses        114      114              
Files Coverage Δ
democracy_club/apps/core/views.py 100.00% <100.00%> (ø)
democracy_club/apps/hermes/admin.py 100.00% <ø> (ø)
democracy_club/apps/hermes/models.py 94.28% <100.00%> (+0.20%) ⬆️
democracy_club/apps/hermes/views.py 92.45% <100.00%> (+1.75%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VirginiaDooley VirginiaDooley force-pushed the hotfix/blog-tags branch 4 times, most recently from af319df to 48644f6 Compare October 18, 2023 15:09
@VirginiaDooley VirginiaDooley marked this pull request as ready for review October 18, 2023 15:09
("where_do_i_vote", "WDIV"),
("election_leaflets", "electionleaflets"),
("blog", "blog"),
("WCIVF", "Who Can I Vote For?"),
Copy link
Contributor Author

@VirginiaDooley VirginiaDooley Oct 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused about what we actually want here vs what is possible. We render the items on the left in the view and the corresponding items on the right in the admin menu. @pmk01

@VirginiaDooley VirginiaDooley force-pushed the hotfix/blog-tags branch 8 times, most recently from b3a06ed to 36a459a Compare October 20, 2023 13:26
- Add alt text to blog hero
- Autogenerate blog slugs
- Add featured posts to context
- Render post tag menu
- Change latest posts header
- Update blog tags with instructions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alt text for blog header images
1 participant