Merge pull request #9 from niklasf/fix-step-5.2

Fix missing ln for B in step 5.2
DenialAdams · Nov 8, 2024 · 2e54ce7 · 2e54ce7
2 parents 6369449 + fa36fd6
commit 2e54ce7
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/lib.rs b/src/lib.rs
@@ -237,7 +237,7 @@ pub fn new_rating(
             let delta_squared = delta * delta;
             let rd_squared = prior_rating.deviation * prior_rating.deviation;
             let mut b = if delta_squared > rd_squared + v {
-                delta_squared - rd_squared - v
+                (delta_squared - rd_squared - v).ln()
             } else {
                 let mut k = 1.0;
                 while f(
@@ -281,7 +281,7 @@ pub fn new_rating(
                     sys_constant,
                 );
                 // b
-                if fc * fb < 0.0 {
+                if fc * fb <= 0.0 {
                     a = b;
                     fa = fb;
                 } else {