posix: Return EINVAL on seeking on a sysfs directory

Dennisbonke · Oct 23, 2023 · f7a4f23 · f7a4f23
1 parent 6a0e246
commit f7a4f23
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/posix/subsystem/src/sysfs.cpp b/posix/subsystem/src/sysfs.cpp
@@ -119,6 +119,11 @@ void DirectoryFile::handleClose() {
 	_cancelServe.cancel();
 }
 
+// TODO: Verify that this is correct
+async::result<frg::expected<Error, off_t>> DirectoryFile::seek(off_t, VfsSeek) {
+	co_return Error::illegalArguments;
+}
+
 // TODO: This iteration mechanism only works as long as _iter is not concurrently deleted.
 async::result<ReadEntriesResult> DirectoryFile::readEntries() {
 	if(_iter != _node->_entries.end()) {

diff --git a/posix/subsystem/src/sysfs.hpp b/posix/subsystem/src/sysfs.hpp
@@ -66,6 +66,7 @@ struct DirectoryFile final : File {
 
 	FutureMaybe<ReadEntriesResult> readEntries() override;
 	helix::BorrowedDescriptor getPassthroughLane() override;
+	async::result<frg::expected<Error, off_t>> seek(off_t offset, VfsSeek whence) override;
 
 private:
 	// TODO: Remove this and extract it from the associatedLink().