Fix erroneous URL-encoding of the Maven groupId

Fixes #4601 Signed-off-by: nscuro <[email protected]>
DependencyTrack · Jan 31, 2025 · 0cf231e · 0cf231e
1 parent 9bef0c9
commit 0cf231e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/main/java/org/dependencytrack/tasks/repositories/MavenMetaAnalyzer.java b/src/main/java/org/dependencytrack/tasks/repositories/MavenMetaAnalyzer.java
@@ -76,7 +76,7 @@ public RepositoryType supportedRepositoryType() {
     public MetaModel analyze(final Component component) {
         final MetaModel meta = new MetaModel(component);
         if (component.getPurl() != null) {
-            final String mavenGavUrl = urlEncode(component.getPurl().getNamespace().replaceAll("\\.", "/")) + "/" + urlEncode(component.getPurl().getName());
+            final String mavenGavUrl = urlEncode(component.getPurl().getNamespace()).replaceAll("\\.", "/") + "/" + urlEncode(component.getPurl().getName());
             final String url = String.format(baseUrl + REPO_METADATA_URL, mavenGavUrl);
             try (final CloseableHttpResponse response = processHttpRequest(url)) {
                 if (response.getStatusLine().getStatusCode() == HttpStatus.SC_OK) {

diff --git a/src/test/java/org/dependencytrack/tasks/repositories/MavenMetaAnalyzerTest.java b/src/test/java/org/dependencytrack/tasks/repositories/MavenMetaAnalyzerTest.java
@@ -54,4 +54,5 @@ public void testAnalyzerForScalaComponent() throws Exception {
         Assert.assertNotNull(metaModel.getLatestVersion());
         Assert.assertNotNull(metaModel.getPublishedTimestamp());
     }
+
 }
-Original file line number
+Diff line change
@@ Expand Up @@
             Assert.assertNotNull(metaModel.getLatestVersion());
             Assert.assertNotNull(metaModel.getPublishedTimestamp());
         }
     }