Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix onlyOutdated ungrouped component filtering #4511

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

sedan07
Copy link
Contributor

@sedan07 sedan07 commented Jan 3, 2025

Description

Fixes onlyOutdated filter when listing a project's components missing any ungrouped (outdated) components, such as Python packages.

Addressed Issue

Fixes #4510

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

nscuro
nscuro previously approved these changes Jan 3, 2025
Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nscuro nscuro added defect Something isn't working backport/4.12.3 PRs to be backported to version 4.12.3 labels Jan 3, 2025
@nscuro nscuro added this to the 4.13 milestone Jan 3, 2025
@sedan07 sedan07 force-pushed the bugfix/issue-4510 branch from 40734fd to 5276bb2 Compare January 3, 2025 14:08
@sedan07
Copy link
Contributor Author

sedan07 commented Jan 3, 2025

@nscuro sorry, fixed tests.

@nscuro
Copy link
Member

nscuro commented Jan 3, 2025

Strange. Tests should be executing again but they don't. And I'm not given an option to approve the CI execution either. @sedan07 could you please amend your commit once more, to trigger a new CI run?

@sedan07 sedan07 force-pushed the bugfix/issue-4510 branch from 5276bb2 to 4fc5b23 Compare January 3, 2025 15:53
@sedan07
Copy link
Contributor Author

sedan07 commented Jan 3, 2025

@nscuro I wonder if requesting you re-review it will force the option to appear.

@sedan07 sedan07 requested a review from nscuro January 3, 2025 15:54
@nscuro nscuro dismissed their stale review January 3, 2025 15:56

Testing if dismissing my previous approval causes CI to trigger again.

@nscuro
Copy link
Member

nscuro commented Jan 3, 2025

It doesn't. Really odd. Removing my approval also didn't do the trick.

@nscuro
Copy link
Member

nscuro commented Jan 3, 2025

Ok, the option was visible in GitHub mobile for some reason.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for b70ecc81 (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b70ecc8) Report Missing Report Missing Report Missing
Head commit (4fc5b23) 23013 18283 79.45%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4511) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@nscuro nscuro merged commit 1927023 into DependencyTrack:master Jan 3, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/4.12.3 PRs to be backported to version 4.12.3 defect Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to filter components by outdated versions for components without namespace/group
2 participants