-
-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix onlyOutdated ungrouped component filtering #4511
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
40734fd
to
5276bb2
Compare
@nscuro sorry, fixed tests. |
Strange. Tests should be executing again but they don't. And I'm not given an option to approve the CI execution either. @sedan07 could you please amend your commit once more, to trigger a new CI run? |
Fixes: DependencyTrack#4510 Signed-off-by: Seb Dangerfield <[email protected]>
5276bb2
to
4fc5b23
Compare
@nscuro I wonder if requesting you re-review it will force the option to appear. |
Testing if dismissing my previous approval causes CI to trigger again.
It doesn't. Really odd. Removing my approval also didn't do the trick. |
Ok, the option was visible in GitHub mobile for some reason. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
Description
Fixes onlyOutdated filter when listing a project's components missing any ungrouped (outdated) components, such as Python packages.
Addressed Issue
Fixes #4510
Additional Details
N/A
Checklist
This PR implements an enhancement, and I have provided tests to verify that it works as intendedThis PR introduces changes to the database model, and I have added corresponding update logicThis PR introduces new or alters existing behavior, and I have updated the documentation accordingly