Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2794: fix different result for affected projects of aliases #4517

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sephiroth-j
Copy link
Contributor

@sephiroth-j sephiroth-j commented Jan 5, 2025

Description

The list of projects affected by a specific vulnerability now also contains projects that are affected by aliases of the specified vulnerability. This ensures that the list of affected projects is the same for all aliases of a vulnerability.

Addressed Issue

fixes #2794

Additional Details

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

some tests check for specific error messages in english thait fail when running them with different locale settings

Signed-off-by: Ronny Perinke <[email protected]>
for example `target\generated-sources\trivy\proto\**\*.java` do not pass the checks

Signed-off-by: Ronny Perinke <[email protected]>
Copy link

codacy-production bot commented Jan 5, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.03% (target: -1.00%) 92.86% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (72e582c) 23013 18283 79.45%
Head commit (02787d4) 23016 (+3) 18292 (+9) 79.48% (+0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4517) 28 26 92.86%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@sephiroth-j sephiroth-j force-pushed the issue-2794-fix-different-result-for-affected-projects-of-aliases branch from 2485cd3 to 02787d4 Compare January 6, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

different result for affected projects of aliases
1 participant