Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DbUtil not being initialized #1058

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Fix DbUtil not being initialized #1058

merged 1 commit into from
Feb 13, 2025

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Feb 12, 2025

Description

Fixes DbUtil not being initialized.

Some legacy code ported over from v4 still uses DbUtil#isPostgreSQL checks to determine if certain SQL syntax can be used.

Since our move to Liquibase, DbUtil has not been initialized anymore, and hence always returned false for the aforementioned check.

Ultimately, usages of DbUtil should be removed entirely.

Addressed Issue

N/A

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

Some legacy code ported over from v4 still uses `DbUtil#isPostgreSQL` checks to determine if certain SQL syntax can be used.

Since our move to Liquibase, `DbUtil` has not been initialized anymore, and hence always returned `false` for the aforementioned check.

Ultimately, usages of `DbUtil` should be removed entirely.

Signed-off-by: nscuro <[email protected]>
@nscuro nscuro added the defect Something isn't working label Feb 12, 2025
@nscuro nscuro added this to the 5.6.0 milestone Feb 12, 2025
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 100.00% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (aced98e) 22391 18569 82.93%
Head commit (f2c5e89) 22393 (+2) 18571 (+2) 82.93% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1058) 2 2 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@nscuro nscuro merged commit c48882b into main Feb 13, 2025
9 checks passed
@nscuro nscuro deleted the fix-dbutil-not-initialized branch February 13, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants