Add GetDestructor method #330
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BUYT-1
force-pushed
the
get-destructor
branch
2 times, most recently
from
4c80f12 to
7e8607d
Compare
polyntsov
requested changes
Dec 22, 2023
src/core/model/types/type.h
Outdated
Comment on lines
132
to
134
| virtual Destructor GetDestructor() const { | ||
| return nullptr; | ||
| } |
There was a problem hiding this comment.
Why not make a virtual Desturct method with an empty body in the base class? Given that some types have non-trivial destruction logic and already have method Destruct adding GetDestructor seems a bit excessive. Also, the problem with GetDestructor is a default behavior in the base class, I don't think returning nullptr is a good idea, because call to nullptr will fail.
There was a problem hiding this comment.
I thought it would make sense to check if the type was trivially destructible to avoid pointless calls. Checking for nullptr does just that
BUYT-1
force-pushed
the
get-destructor
branch
from
7e8607d to
c3c744f
Compare
BUYT-1
force-pushed
the
get-destructor
branch
from
c3c744f to
bc62a2a
Compare
|
Nevermind, let's just use #285 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a more convenient way to destruct an object, used in #327, and perhaps it should be used in
TypedColumnDatatoo.