Skip to content

Commit

Permalink
Update GHA versions
Browse files Browse the repository at this point in the history
  • Loading branch information
jgoldfar committed May 20, 2024
1 parent 8dfcc94 commit 6a1e234
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 11 deletions.
7 changes: 4 additions & 3 deletions .github/workflows/docker-compose-verify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,10 @@ jobs:
strategy:
fail-fast: false
matrix:
node: ['14', '16', '18']
node: ['18', '20']
implementation: ['restify', 'plain', 'express', 'koa', 'fastify']
runs-on: 'ubuntu-20.04'
runson: ['ubuntu-20.04', 'ubuntu-22.04']
runs-on: ${{ matrix.runson }}
steps:
- name: Checkout the commit triggering this job
uses: actions/checkout@v4
Expand All @@ -33,7 +34,7 @@ jobs:
docker-compose run -d --service-ports backend npm run start:${{ matrix.implementation }}
- name: Setup Node with npm cache
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}
cache: 'npm'
Expand Down
10 changes: 6 additions & 4 deletions .github/workflows/node-benchmark-containerized.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,16 @@ jobs:
strategy:
fail-fast: false
matrix:
node: ['16', '18']
node: ['16', '18', '20']
implementation: ['restify', 'plain', 'express', 'koa', 'fastify']
runson: ['ubuntu-20.04', 'ubuntu-22.04']
postgresversion: ['14.2-alpine']
# nodeImage: ['node:14-alpine', 'node:16-alpine', 'node:17-alpine']
runs-on: 'ubuntu-20.04'
runs-on: ${{ matrix.runson }}
services:
# label for service - since this job doesn't run in a container, this service is accessible at localhost
database:
image: postgres:14.2-alpine
image: postgres:${{ matrix.postgresversion }}
ports:
- 5432:5432
env:
Expand Down Expand Up @@ -60,7 +62,7 @@ jobs:
PGPASSWORD=password psql -h localhost -U acronymapi --dbname=defaultdb --file=initdb.sql
#
- name: Setup Node with npm cache
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}
cache: 'npm'
Expand Down
10 changes: 6 additions & 4 deletions .github/workflows/node-test-containerized.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,18 @@ jobs:
strategy:
fail-fast: false
matrix:
node: ['16', '18']
runs-on: 'ubuntu-20.04'
node: ['18', '20']
runson: ['ubuntu-20.04', 'ubuntu-22.04']
postgresversion: ['14.2-alpine']
runs-on: ${{ matrix.runson }}
# These run alongside the job.
# See:
# - https://docs.github.com/en/actions/using-containerized-services/about-service-containers
# - https://docs.github.com/en/actions/using-containerized-services/creating-postgresql-service-containers
services:
# label for service - since this job doesn't run in a container, this service is accessible at localhost
database:
image: postgres:14.2-alpine
image: postgres:${{ matrix.postgresversion }}
ports:
- 5432:5432
env:
Expand Down Expand Up @@ -51,7 +53,7 @@ jobs:
# https://github.com/actions/setup-node
# https://github.com/actions/cache is no longer needed with setup-node v2
- name: Setup Node with npm cache
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}
cache: 'npm'
Expand Down

0 comments on commit 6a1e234

Please sign in to comment.