Collection, TreeView, FileManager: get rid of unused this._selectionC…

…hangePromise (#28862) Signed-off-by: Anton Kuznetsov <[email protected]>
DevExpress · Jan 29, 2025 · bf7f61f · bf7f61f
1 parent faf7b43
commit bf7f61f
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 17 deletions.
diff --git a/packages/devextreme/js/__internal/ui/collection/m_collection_widget.edit.ts b/packages/devextreme/js/__internal/ui/collection/m_collection_widget.edit.ts
@@ -545,8 +545,6 @@ class CollectionWidget<
     const { addedItemKeys, removedItemKeys } = args;
 
     if (this._rendered && (addedItemKeys.length || removedItemKeys.length)) {
-      // @ts-expect-error ts-error
-      const selectionChangePromise = this._selectionChangePromise;
       if (!this._rendering) {
         const addedSelection = [];
         const removedSelection = [];
@@ -574,12 +572,9 @@ class CollectionWidget<
         this._updateSelection(addedSelection, removedSelection);
       }
 
-      // eslint-disable-next-line @typescript-eslint/no-floating-promises
-      when(selectionChangePromise).done(() => {
-        this._actions.onSelectionChanged({
-          addedItems: args.addedItems,
-          removedItems: args.removedItems,
-        });
+      this._actions.onSelectionChanged({
+        addedItems: args.addedItems,
+        removedItems: args.removedItems,
       });
     }
   }

diff --git a/packages/devextreme/js/__internal/ui/tree_view/m_tree_view.base.ts b/packages/devextreme/js/__internal/ui/tree_view/m_tree_view.base.ts
@@ -214,12 +214,9 @@ const TreeViewBase = (HierarchicalCollectionWidget as any).inherit({
   _syncSelectionOptions: asyncNoop,
 
   _fireSelectionChanged() {
-    const selectionChangePromise = this._selectionChangePromise;
-    when(selectionChangePromise).done(() => {
-      this._createActionByOption('onSelectionChanged', {
-        excludeValidators: ['disabled', 'readOnly'],
-      })();
-    });
+    this._createActionByOption('onSelectionChanged', {
+      excludeValidators: ['disabled', 'readOnly'],
+    })();
   },
 
   _createSelectAllValueChangedAction() {

diff --git a/packages/devextreme/js/ui/file_manager/ui.file_manager.items_list.thumbnails.list_box.js b/packages/devextreme/js/ui/file_manager/ui.file_manager.items_list.thumbnails.list_box.js
@@ -2,7 +2,7 @@ import { getOuterWidth, getOuterHeight, getInnerWidth, getInnerHeight } from '..
 import $ from '../../core/renderer';
 import { extend } from '../../core/utils/extend';
 import { isDefined } from '../../core/utils/type';
-import { Deferred, when } from '../../core/utils/deferred';
+import { Deferred } from '../../core/utils/deferred';
 
 import holdEvent from '../../common/core/events/hold';
 import { addNamespace, isCommandKeyPressed } from '../../common/core/events/utils/index';
@@ -284,7 +284,6 @@ class FileManagerThumbnailListBox extends CollectionWidget {
         const removedItemKeys = args.removedItemKeys;
 
         if(this._rendered && (addedItemKeys.length || removedItemKeys.length)) {
-            const selectionChangePromise = this._selectionChangePromise;
             if(!this._rendering) {
                 const addedSelection = [];
                 let normalizedIndex;
@@ -309,7 +308,7 @@ class FileManagerThumbnailListBox extends CollectionWidget {
                 this._updateSelection(addedSelection, removedSelection);
             }
 
-            when(selectionChangePromise).done(() => this._fireSelectionChangeEvent(args));
+            this._fireSelectionChangeEvent(args);
         }
     }