Map - unskip demos tests #28533
Open
Map - unskip demos tests #28533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EugeniyKiyashko
previously approved these changes
Dec 25, 2024
pomahtri
requested changes
Jan 13, 2025
apps/demos/testing/common.test.js
Outdated
| 'Map', | ||
| ]; | ||
|
|
||
| const EXPECTED_CONSOLE_MESSAGES = { |
There was a problem hiding this comment.
Please, move this constant to known-warning.json file
Also, it would be good if you guys could plan task with moving other consts to according files too (like, create known-a11y-issues.json, known-screenshot-issues.json etc)
For now this file is unnecessarily big and complex
EugeniyKiyashko
force-pushed
the
tryUnskipMapTests__24_2
branch
from
8034424 to
3c87c99
Compare
EugeniyKiyashko
force-pushed
the
tryUnskipMapTests__24_2
branch
from
3c87c99 to
b6e8c57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.