Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 T1268664: DataGrid focused row twitches when at least one column is fixed #28879

Open
wants to merge 3 commits into
base: 25_1
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
34 changes: 21 additions & 13 deletions e2e/testcafe-devextreme/tests/dataGrid/stickyColumns/appearance.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,23 +11,31 @@ const DATA_GRID_SELECTOR = '#container';
fixture.disablePageReloads`FixedColumns - appearance`
.page(url(__dirname, '../../container.html'));

[
Themes.genericLight,
Themes.genericLightCompact,
Themes.materialBlue,
Themes.materialBlueCompact,
Themes.fluentBlue,
Themes.fluentBlueCompact,
].forEach(
(theme) => {
test('Row height for selected, focus and edit state should not differ from the default one', async (t) => {
([
[Themes.genericLight, false],
[Themes.genericLightCompact, false],
[Themes.materialBlue, false],
[Themes.materialBlueCompact, false],
[Themes.fluentBlue, false],
[Themes.fluentBlueCompact, false],
[Themes.genericLight, true],
[Themes.genericLightCompact, true],
[Themes.materialBlue, true],
[Themes.materialBlueCompact, true],
[Themes.fluentBlue, true],
[Themes.fluentBlueCompact, true],
] as const).forEach(
([theme, showRowLines]) => {
// T1268664
const showRowLinesState = `showRowLines=${showRowLines ? 'true' : 'false'}`;
test(`Row height for selected, focus and edit state should not differ from the default one if ${showRowLinesState}`, async (t) => {
const { takeScreenshot, compareResults } = createScreenshotsComparer(t);

const dataGrid = new DataGrid(DATA_GRID_SELECTOR);

await t.expect(dataGrid.isReady()).ok();

await takeScreenshot(`datagrid_default_state_(${theme}).png`, dataGrid.element);
await takeScreenshot(`datagrid_default_state_with_${showRowLinesState}_(${theme}).png`, dataGrid.element);

await t
.click(dataGrid.getDataRow(2).getCommandCell(41).getButton(0))
Expand All @@ -36,7 +44,7 @@ fixture.disablePageReloads`FixedColumns - appearance`

await t.debug();

await takeScreenshot(`datagrid_selected_focused_edit_state_(${theme}).png`, dataGrid.element);
await takeScreenshot(`datagrid_selected_focused_edit_state_with_${showRowLinesState}_(${theme}).png`, dataGrid.element);

await t
.expect(compareResults.isValid())
Expand All @@ -62,7 +70,7 @@ fixture.disablePageReloads`FixedColumns - appearance`
allowColumnReordering: true,
allowColumnResizing: true,
focusedRowEnabled: true,
showRowLines: false,
showRowLines,
selection: {
mode: 'multiple',
},
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading