Update long-email.md #39
Conversation
There was a problem hiding this comment.
Thanks, @akhaiat2.
I think the point of the issue was to make the e-mail less wordy while still maintaining the key points.
(No need to actually do this, I just wanted to use the "Request changes" option so we have an example in the repo.)
There are two good practices there could be added to this PR:
-
Including a message in the Pull Request explaining what you did and why. You can, for example, link to the original issue by making the PR message simply "Fix issue Shorten e-mail #22". This will link from the issue to the PR and vice-versa. It will also close the issue when the PR is merged to main. (Here's the documentation on this linking practice)
-
Adding a reviewer to the PR (on the top right corner), so someone is notified that it has been open.
No description provided.