Update README.md

DevTeam · Dec 15, 2024 · bcc6aef · bcc6aef
1 parent d71234b
commit bcc6aef
Show file tree

Hide file tree

Showing 7 changed files with 16 additions and 6 deletions.
diff --git a/readme/check-for-a-root.md b/readme/check-for-a-root.md
@@ -26,7 +26,7 @@ partial class Composition
     private static readonly HashSet<(Type type, object? tag)> Roots = [];
 
     // Check that the root can be resolved by Resolve methods
-    internal static bool HasRoot(Type type, object? key = default) =>
+    internal static bool HasRoot(Type type, object? key = null) =>
         Roots.Contains((type, key));
 
     static void Setup() =>

diff --git a/readme/generic-root-arguments.md b/readme/generic-root-arguments.md
@@ -29,7 +29,7 @@ DI.Setup(nameof(Composition))
     .Root<IService<TT>>("GetMyService");
 
 var composition = new Composition();
-var service = composition.GetMyService<int>(someArg: 33);
+IService<int> service = composition.GetMyService<int>(someArg: 33);
 ```
 
 The following partial class will be generated:

diff --git a/readme/tag-type.md b/readme/tag-type.md
@@ -36,6 +36,8 @@ class Service(
 
 DI.Setup(nameof(Composition))
     // Tag.Type here is the same as typeof(AbcDependency)
+    // The `default` tag is used to resolve dependencies
+    // when the tag was not specified by the consumer
     .Bind<IDependency>(Tag.Type, default).To<AbcDependency>()
     // Tag.Type here is the same as typeof(XyzDependency)
     .Bind<IDependency>(Tag.Type).As(Lifetime.Singleton).To<XyzDependency>()

diff --git a/readme/tags.md b/readme/tags.md
@@ -37,6 +37,8 @@ class Service(
 }
 
 DI.Setup(nameof(Composition))
+    // The `default` tag is used to resolve dependencies
+    // when the tag was not specified by the consumer
     .Bind<IDependency>("AbcTag", default).To<AbcDependency>()
     .Bind<IDependency>("XyzTag")
     .As(Lifetime.Singleton)

diff --git a/readme/weak-reference.md b/readme/weak-reference.md
@@ -15,7 +15,7 @@ class Service(WeakReference<IDependency> dependency) : IService
     public IDependency? Dependency =>
         dependency.TryGetTarget(out var value)
             ? value
-            : default;
+            : null;
 }
 
 DI.Setup(nameof(Composition))

diff --git a/tests/Pure.DI.UsageTests/Advanced/TagTypeScenario.cs b/tests/Pure.DI.UsageTests/Advanced/TagTypeScenario.cs
@@ -11,6 +11,7 @@
 // ReSharper disable ArrangeTypeModifiers
 // ReSharper disable ClassNeverInstantiated.Global
 
+// ReSharper disable PreferConcreteValueOverDefault
 namespace Pure.DI.UsageTests.Advanced.TagTypeScenario;
 
 using Shouldly;
@@ -53,8 +54,10 @@ public void Run()
     {
 // {
         DI.Setup(nameof(Composition))
-            // Tag.Type here is the same as typeof(AbcDependency) 
-            .Bind<IDependency>(Tag.Type, null).To<AbcDependency>()
+            // Tag.Type here is the same as typeof(AbcDependency)
+            // The `default` tag is used to resolve dependencies
+            // when the tag was not specified by the consumer
+            .Bind<IDependency>(Tag.Type, default).To<AbcDependency>()
             // Tag.Type here is the same as typeof(XyzDependency)
             .Bind<IDependency>(Tag.Type).As(Lifetime.Singleton).To<XyzDependency>()
             .Bind<IService>().To<Service>()

diff --git a/tests/Pure.DI.UsageTests/Basics/TagsScenario.cs b/tests/Pure.DI.UsageTests/Basics/TagsScenario.cs
@@ -12,6 +12,7 @@
 // ReSharper disable ArrangeTypeModifiers
 // ReSharper disable ClassNeverInstantiated.Global
 
+// ReSharper disable PreferConcreteValueOverDefault
 namespace Pure.DI.UsageTests.Basics.TagsScenario;
 
 using Shouldly;
@@ -57,7 +58,9 @@ public void Run()
         // Resolve = Off
 // {
         DI.Setup(nameof(Composition))
-            .Bind<IDependency>("AbcTag", null).To<AbcDependency>()
+            // The `default` tag is used to resolve dependencies
+            // when the tag was not specified by the consumer
+            .Bind<IDependency>("AbcTag", default).To<AbcDependency>()
             .Bind<IDependency>("XyzTag")
             .As(Lifetime.Singleton)
             .To<XyzDependency>()