Allow UTF-16 surrogate pairs in Base64 decoded strings #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Base64 decoding fails with
<Invalid Base64>
when UTF-16 surrogate pairs are encountered. Surrogate pairs allow the Unicode encoding to encode characters with codepoints greater than 0xFFFF in UTF-16. In the linked issue the the example document includes the key emoji (🗝️) which is represented in UTF-16 as\ud83d\udddd
.Issue Number: DevToys-app/DevToys#1461
What is the new behavior?
Other information
Unicode documentation for UTF-16 surrogate pairs
Quality check
Before creating this PR: