Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/lesson info modal #75

Closed
wants to merge 4 commits into from
Closed

Feat/lesson info modal #75

wants to merge 4 commits into from

Conversation

recepcankaya
Copy link
Collaborator

@recepcankaya recepcankaya commented Jan 19, 2024

Change SideDrawer component to shadcn Dialog component.

API Updates

  • Add shadcn dialog component

New Features (required)

  • to test the new component, please open tracks/intro-to-ethereum/1

Fixes #67
Will close issue #67 on merge

Copy link

vercel bot commented Jan 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
academy-turbo ✅ Ready (Inspect) Visit Preview Jan 19, 2024 0:46am
academy-turbo-storybook ✅ Ready (Inspect) Visit Preview Jan 19, 2024 0:46am

Copy link
Contributor

@wolovim wolovim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for jumping in!

  • first, looks like you need to rebase from main and resolve conflicts
  • based on the image below, it seems that question titles arent displayed
  • no styles are applied on selection of answer (or hover)
  • question submit button color doesnt match figma
  • form cancel button text and color are the same (unreadable) until you hover
Screenshot 2024-01-19 at 10 31 58 AM

@recepcankaya
Copy link
Collaborator Author

@wolovim i have seen a new component called LessonInformationalModal and mine is LessonInfoModal. I am confused rn. Are they supposed to do the same thing?

@wolovim
Copy link
Contributor

wolovim commented Jan 20, 2024

damn. i think its the same @recepcankaya. @Markkos89 mentioned the QuestionsModal in this comment in #70, but the InformationalModal is created in the same PR:

created new LessonQuestionsModal (cc @recepcankaya sorry for creating it, mate, I hope my code helps in the worst case)

github email notifications are noisy and can be easy to miss, so next time theres potential overlap like this, lets make sure a DM goes out @Markkos89.

looks like theres still at least a bit of styling to do from markko's component - the selected answer is unstyled, for example. to wrap up this unit of work, i suspect its quickest to abandon this component and finish the last of any styling from the LessonInformationalModal? sorry to see work get thrown out; lets tighten up communication to avoid that in the future.

@wolovim
Copy link
Contributor

wolovim commented Jan 22, 2024

again, sorry to see this work rendered obsolete @recepcankaya. going to close this PR and encourage any new iterations start fresh from the latest on the main branch.

@wolovim wolovim closed this Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants