-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/lesson info modal #75
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for jumping in!
- first, looks like you need to rebase from
main
and resolve conflicts - based on the image below, it seems that question titles arent displayed
- no styles are applied on selection of answer (or hover)
- question submit button color doesnt match figma
- form cancel button text and color are the same (unreadable) until you hover

@wolovim i have seen a new component called |
damn. i think its the same @recepcankaya. @Markkos89 mentioned the QuestionsModal in this comment in #70, but the InformationalModal is created in the same PR:
github email notifications are noisy and can be easy to miss, so next time theres potential overlap like this, lets make sure a DM goes out @Markkos89. looks like theres still at least a bit of styling to do from markko's component - the selected answer is unstyled, for example. to wrap up this unit of work, i suspect its quickest to abandon this component and finish the last of any styling from the |
again, sorry to see this work rendered obsolete @recepcankaya. going to close this PR and encourage any new iterations start fresh from the latest on the |
Change SideDrawer component to shadcn Dialog component.
API Updates
New Features (required)
tracks/intro-to-ethereum/1
Fixes #67
Will close issue #67 on merge