Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: RainbowKit connect wallet button and more #228

Merged
merged 17 commits into from
Aug 16, 2023

Conversation

Markkos89
Copy link
Collaborator

@Markkos89 Markkos89 commented Aug 4, 2023

In this PR I added RainbowKit and RainbowkitSiweNextAuth and now we are handling the authentication trough RainbowKit.
There is no need to create the requested component so #211 can be closed

I'm adding this to the new version branch and will continue to fix some of the bugs and details mentioned on #225 #226 and #227

@kempsterrrr @wolovim with this PR we will need to do some changes to include a Wallet Connect Cloud project (two projects, one for production and another one for staging/dev).

We need the project ID to be stored in the NEXT_PUBLIC_WALLET_CONNECT_ID env var

  • for creating the Wallet Connect Cloud project we have to follow some steps of registration, create the project, allow the domains used so they can use the project's ID, and after that, we have to validate the domain ownership.
    The last step is done by adding a TXT record on the domain provider config with the value set by Wallet Connect Cloud.

Lastly, to move to production we have to "publish" the project and that goes to review by their team. So we will have to consider this regarding the timing of deployments. At least we can create the projects and get the projects IDs for now.

@kempsterrrr have in mind that to be able to add the preferred partner we need this projectID for the configuration, as for much other options that we can use.

Already tested with my personal account of Wallet Connect Cloud and with a dummy domain I have.

@vercel
Copy link

vercel bot commented Aug 4, 2023

@Markkos89 is attempting to deploy a commit to the Developerdao Team on Vercel.

A member of the Team first needs to authorize it.

@Markkos89 Markkos89 added the enhancement New feature or request label Aug 4, 2023
@vercel
Copy link

vercel bot commented Aug 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
academy ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 5:29am

@kempsterrrr
Copy link
Member

From #211

@Markkos89 - I've set up a wallet connect cloud account using [email protected] - let me know who is the best person to give access too.

I wonder if it makes sense to create an [email protected] email address, switch the email and give someone in the team access to that account?

@kempsterrrr have in mind that to be able to add the preferred partner, we need this projectID for the configuration, as for much other options that we can use.

Amazing thank youuu

@Markkos89
Copy link
Collaborator Author

Great news, thank you again Kemps!! 💪 🚀

@Markkos89
Copy link
Collaborator Author

  • added zerion to wallet providers list
  • fixed rerenders error api call
  • cleaned up unnused code

@vercel
Copy link

vercel bot commented Aug 9, 2023

Deployment failed with the following error:

The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.

@Markkos89
Copy link
Collaborator Author

Ready to proceed to merge this and test in staging

next steps would be to fill the db data with the lessons and the lessons quiz file names and continue development

cc: @wolovim @kempsterrrr

@Markkos89
Copy link
Collaborator Author

Ready to proceed to merge this and test in staging

next steps would be to fill the db data with the lessons and the lessons quiz file names and continue development

cc: @wolovim @kempsterrrr

pushing this to staging

@Markkos89 Markkos89 merged commit 72c63e8 into Developer-DAO:feat/wallet Aug 16, 2023
1 check passed
@Markkos89 Markkos89 deleted the feat/rainbow-siwe branch September 20, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants