Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loader-prop #217

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Loader-prop #217

merged 2 commits into from
Dec 4, 2023

Conversation

bassem97
Copy link
Contributor

@bassem97 bassem97 commented Dec 3, 2023

FIX https://github.com/uNotesOfficial/unotes-next/issues/1071

Add the ability to accept a loader from the parent component, so w'll be able to pass either uNotes spinner book or the circular progress like this:
screen-capture (3).webm

Took 22 minutes
Took 11 minutes
Copy link
Contributor

@MohamedBechirMejri MohamedBechirMejri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gg

@MohamedBechirMejri MohamedBechirMejri merged commit 9bf2e46 into master Dec 4, 2023
4 checks passed
@MohamedBechirMejri MohamedBechirMejri deleted the Loader-prop branch December 4, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants