Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): added other essential open source documentation files #245

Merged

Conversation

amjedidiah
Copy link
Collaborator

  • Added CONTRIBUTING.md with development and PR guidelines
  • Added CODE_OF_CONDUCT.md based on Contributor Covenant
  • Added SECURITY.md with vulnerability reporting process
  • Added issue and PR templates
  • Updated README.md with documentation references and fixed lint errors
  • Updated .gitignore file to ignore VSCode workspace settings

- Added `CONTRIBUTING.md` with development and PR guidelines
- Added `CODE_OF_CONDUCT.md` based on Contributor Covenant
- Added `SECURITY.md` with vulnerability reporting process
- Added issue and PR templates
- Updated `README.md` with documentation references and fixed lint errors
- Updated `.gitignore` file to ignore VSCode workspace settings
@amjedidiah amjedidiah changed the title chore(docs): added essential open source documentation files chore(docs): added other essential open source documentation files Nov 4, 2024
@BSalaeddin BSalaeddin self-requested a review November 22, 2024 14:19
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion:

I believe it would be helpful to include a field where the reporter can specify the exact version or commit hash of the project they are reporting on. This will make it easier to identify and address version-specific issues accurately.

image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BSalaeddin, done

README.md Outdated
![upup_logo_dark](https://github.com/DevinoSolutions/upup/assets/43147238/b5477db9-cb23-43c7-8c12-518beb31af53)

<br/>
An open-source, free-to-use NPM component that easily handles your file upload needs with seamless DigitalOcean Spaces, Amazon S3, Google Drive and OneDrive integration.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion:

Given that the package relies on JSX and React hooks, it would be more precise to describe it as a "React component library" rather than a generic "NPM component," ensuring the description aligns with its core technology stack.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BSalaeddin , done

- updated README to describe package as a "React component library" rather than a generic "NPM component," ensuring the description aligns with its core technology stack
- included field for commit hash in bug report
@MedAmine1212 MedAmine1212 self-requested a review November 26, 2024 19:32
Copy link
Collaborator

@MedAmine1212 MedAmine1212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@amjedidiah amjedidiah merged commit 59a7e40 into DevinoSolutions:master Nov 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants