pre-signed URL upload for better security #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Replaced direct cloud storage configuration with pre-signed URLs - Added pre-signed URL endpoint configuration - Removed cloud storage credentials from frontend - Deleted cloud storage config files - Updated upload logic to use pre-signed URLs - Simplified configuration interface
- Added CORS mode to uploadObject fetch request - Prettier fixes BREAKING CHANGE: Requires S3 bucket CORS configuration
- Added client-side SDK approach for cloud storage providers - Implemented AWS integration with presigned URLs - Added credential refresh and SAS token management - Implemented progress tracking and retry mechanisms - Fixed type errors and improve error handling - Removed unused code and align with latest SDK versions BREAKING CHANGE: Storage configuration requires provider-specific SDK setup
- Added client-side SDK approach for Azure provider - Implemented Azure integration with presigned URLs - Implemented progress tracking - Removed unused code and align with latest SDK versions
- Storage config only requires `provider` and `tokenEndpoint` values
- Added client-side SDK approach for DO provider - Implemented DO integration with presigned URLs
- Unified s3 client-side upload approach for S3 complaint storage providers
- preview url for uploaded files
amjedidiah
changed the title
- made ETag header conditional - removed `previewUrl` from object returned to FE
amjedidiah
force-pushed
the
feat/cloud-storage-sdk-integration
branch
from
e5e1332 to
edfe2ea
Compare
amjedidiah
changed the title
BSalaeddin
reviewed
Nov 25, 2024
There was a problem hiding this comment.
Variable Naming Improvements suggestions
-
files: Rename touploadedFilesorselectedFilesin components and hooks that expose it to developers. This will make its purpose clearer when returned by hooks or used as props in components (e.g., inUpupUploader.tsx). -
onChange: Rename toonFileSelectionChangefor props exposed by components to better describe its role in handling file selection updates. -
toBeCompressed: Rename toshouldCompressfor component props to better reflect its boolean nature and improve clarity for developers configuring the component. -
keys: Rename touploadedFileKeysif returned by hooks or methods, to clarify that it represents the identifiers of successfully uploaded files.
Renames - `files` to `selectedFiles` - `onChange` to `onFilesSelected` - `onFilesChange` to `onPrepareFiles` - `toBeCompressed` to `shouldCompress` - `keys` to `uploadedFileKeys`
BSalaeddin
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.