Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/ui-customisations #258

Merged
merged 30 commits into from
Jan 31, 2025

Conversation

amjedidiah
Copy link
Collaborator

Upup Pull Request Template

Description

  • Container: Background, size and border radius
  • Progress bar & percentage style
  • Files & previews container (grid, flex,...)
  • Providers list style
  • Each button style & colour individually: including remove file button

AND more

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings

- fixed bug with preview
- properly managed preview and file click event handlers
- icon support for more file extensions
- deleted unused provider file
- properly managed conditions for different s3 uploaders
- returned public url for uploaded image in response to client
- fix for files being selected multiple times
- removing `uploads` from the file upload key
- refactored app to minimise code repetitions

#### Fixes
-   onFileSelected fix
-   Fix for same file selected multiple times
-   Fix for Google Drive loading
- reverting back to using a single box to manage preview and adapter options
-   [x] Cancel button to be visible when adding More files
-   [x] Show icon of drive instead of name
-   [x] Replace user name with user image/icon in drive selection
-   [x] Apply background color same as Preview component in drive selection
-   [x] Search functionality for drive files
- [x] Progress bar  for single uploads
- [x] Progress bar and progress value for all uploads
- [x] Sonner toast as default error handler instead of `console.error`
- [x] minor design fixes
-   [x] allProgress: Math.round
-   [x] individual progress bar: rounded bottom only
-   [x] show warning for existing file selected again
-   [x] preview thumbnail: available for supported types
-   [x] preview: only show for supported file types
-   [x] disable all buttons during upload
-   [x] Uploads done with errors should not show Done button
- single storybook story with customizable controls
- minor design changes
-   [x] Container: Background, size and border radius
-   [x] Progress bar & percentage style
-   [x] Files & previews container (grid, flex,...)
-   [x] Providers list style
-   [x] Each button style & colour individually: including remove file button

AND more
@amjedidiah amjedidiah changed the title Feat/ui-customisations [WIP] Feat/ui-customisations Jan 24, 2025
- more ui customizations
- improved overall background customisation support
- file preview fix
- lint fixes
- improved camera image preview
- fix for starting file limit in Storybook
- better file progress tracking and style
@amjedidiah amjedidiah changed the title [WIP] Feat/ui-customisations Feat/ui-customisations Jan 27, 2025
@amjedidiah amjedidiah force-pushed the feat/ui-customisations branch from 53e3338 to ef7686b Compare January 27, 2025 13:59
@amjedidiah amjedidiah force-pushed the feat/ui-customisations branch from ef7686b to 34a151a Compare January 27, 2025 18:59
- max z-index for powered by upup
- file preview fix
- proper preview for storybook component
Copy link
Collaborator

@BSalaeddin BSalaeddin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @amjedidiah

- renamed `adapterList` to `adapterButtonList` and `adapterDriveLoading` to `driveLoading` to match naming convention
- moved `loader` props into `icon` props
- improved `validateConfig` functionality
- updated README with `Getting Started` docs from landing page
Copy link
Collaborator

@MedAmine1212 MedAmine1212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix prettier issues & merge @amjedidiah

@amjedidiah
Copy link
Collaborator Author

Fix prettier issues & merge @amjedidiah

@MedAmine1212 Done

@MedAmine1212 MedAmine1212 merged commit f8340ed into DevinoSolutions:master Jan 31, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants