-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/ui-customisations #258
Merged
MedAmine1212
merged 30 commits into
DevinoSolutions:master
from
amjedidiah:feat/ui-customisations
Jan 31, 2025
Merged
Feat/ui-customisations #258
MedAmine1212
merged 30 commits into
DevinoSolutions:master
from
amjedidiah:feat/ui-customisations
Jan 31, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixed bug with preview - properly managed preview and file click event handlers - icon support for more file extensions - deleted unused provider file
… with"react Provider"
- properly managed conditions for different s3 uploaders - returned public url for uploaded image in response to client
- fix for files being selected multiple times
- removing `uploads` from the file upload key
- refactored app to minimise code repetitions #### Fixes - onFileSelected fix - Fix for same file selected multiple times - Fix for Google Drive loading
- reverting back to using a single box to manage preview and adapter options
- [x] Cancel button to be visible when adding More files - [x] Show icon of drive instead of name - [x] Replace user name with user image/icon in drive selection - [x] Apply background color same as Preview component in drive selection - [x] Search functionality for drive files
- [x] Progress bar for single uploads - [x] Progress bar and progress value for all uploads - [x] Sonner toast as default error handler instead of `console.error` - [x] minor design fixes
- [x] allProgress: Math.round - [x] individual progress bar: rounded bottom only - [x] show warning for existing file selected again - [x] preview thumbnail: available for supported types - [x] preview: only show for supported file types - [x] disable all buttons during upload - [x] Uploads done with errors should not show Done button
- single storybook story with customizable controls - minor design changes
- [x] Container: Background, size and border radius - [x] Progress bar & percentage style - [x] Files & previews container (grid, flex,...) - [x] Providers list style - [x] Each button style & colour individually: including remove file button AND more
- more ui customizations - improved overall background customisation support - file preview fix - lint fixes - improved camera image preview - fix for starting file limit in Storybook - better file progress tracking and style
53e3338
to
ef7686b
Compare
ef7686b
to
34a151a
Compare
- max z-index for powered by upup - file preview fix - proper preview for storybook component
BSalaeddin
reviewed
Jan 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me @amjedidiah
- renamed `adapterList` to `adapterButtonList` and `adapterDriveLoading` to `driveLoading` to match naming convention - moved `loader` props into `icon` props - improved `validateConfig` functionality - updated README with `Getting Started` docs from landing page
MedAmine1212
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix prettier issues & merge @amjedidiah
@MedAmine1212 Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upup Pull Request Template
Description
AND more
Type of change
Checklist