Fix/final-review #259
Merged
Fix/final-review #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Replaced direct cloud storage configuration with pre-signed URLs - Added pre-signed URL endpoint configuration - Removed cloud storage credentials from frontend - Deleted cloud storage config files - Updated upload logic to use pre-signed URLs - Simplified configuration interface
- Added CORS mode to uploadObject fetch request - Prettier fixes BREAKING CHANGE: Requires S3 bucket CORS configuration
- Added client-side SDK approach for cloud storage providers - Implemented AWS integration with presigned URLs - Added credential refresh and SAS token management - Implemented progress tracking and retry mechanisms - Fixed type errors and improve error handling - Removed unused code and align with latest SDK versions BREAKING CHANGE: Storage configuration requires provider-specific SDK setup
- Added client-side SDK approach for Azure provider - Implemented Azure integration with presigned URLs - Implemented progress tracking - Removed unused code and align with latest SDK versions
- Storage config only requires `provider` and `tokenEndpoint` values
- Added client-side SDK approach for DO provider - Implemented DO integration with presigned URLs
- Unified s3 client-side upload approach for S3 complaint storage providers
- preview url for uploaded files
- made ETag header conditional - removed `previewUrl` from object returned to FE
- changed folder structure to accommodate BE logic
- undid setting `Content-Type ` header when sending fetch request from `uploadObject` - improved logic for `handleError` - improved validation of required configuration - Enhanced error handling by including `xhr.status` and `xhr.statusText` when reporting error from `uploadWithProgress` - fixed issue with build failing when temp dist directory exists
- Configured Jest environment for React components and JSDOM - Added setupTests with necessary mocks for Google, Framer Motion - Implemented detailed test suite for MetaVersion, checkFileType, and s3GeneratePresignedUrl
…graded coverage reporting feat: - Removed Codecov in favour of native Jest coverage reporting in CI - Added GitHub Actions artifact storage for coverage reports - Added detailed coverage threshold checks in CI pipeline - Updated `s3GeneratePresignedUrl` test suite per review to test for Invalid s3ClientConfig and Missing Parameters - Updated jest config to support coverage requirements
- fixed failing tests - replaced test for single frontend component - refactored tests to fix code duplication warning - deleted all references to `version.ts` as it is no longer needed - prettier fixes
…s multiple toasts for a single call added reference to upup full docs in README
- improved logic for checking selected files limit - minor fixes for progress bar - removed console logs
- abstract multiple `classNames.adapterView` calls to single component
MedAmine1212
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upup Pull Request Template
Description
version.tsas it is no longer neededType of change
Checklist