feat(client-dotnet): implement C# NOW-proto client #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacmancoder
force-pushed
the
feat/now-proto-csharp-client
branch
from
b37ee5c to
32a36e5
Compare
CBenoit
approved these changes
Jan 28, 2025
| namespace Devolutions.NowClient | ||
| { | ||
| /// <summary> | ||
| /// Batch(Windows CMD) remote execution session parameters. |
There was a problem hiding this comment.
Suggested change
| /// Batch(Windows CMD) remote execution session parameters. | |
| /// Batch (Windows CMD) remote execution session parameters. |
| <TargetFramework>net8.0</TargetFramework> | ||
| <ImplicitUsings>enable</ImplicitUsings> | ||
| <Nullable>enable</Nullable> | ||
| <Platforms>Win32;x64;ARM64</Platforms> |
There was a problem hiding this comment.
question: No support for Linux/macOS? Is this relying on many platform specific stuff?
There was a problem hiding this comment.
No platform-specific stuff at all, I'll change Win32 to x86, accidentally selected it instead of x86 in solutions configurations via VisualStudio GUI, thanks for spotting!
| namespace Devolutions.NowClient | ||
| { | ||
| /// <summary> | ||
| /// Powershell 7(pwsh) remote execution session parameters. |
There was a problem hiding this comment.
Suggested change
| /// Powershell 7(pwsh) remote execution session parameters. | |
| /// Powershell 7 and higher (pwsh) remote execution session parameters. |
|
Current CI error, I'll look into it Could not find 'dotnet.exe' host for the 'ARM64' architecture.
You can resolve the problem by installing the 'ARM64' .NET. |
awakecoding
approved these changes
Feb 10, 2025
awakecoding
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following: