Evaluate bringing in mainstream fixes #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-A first version of the gui working -Moved sources to a python package -Better OOP in scan.py -Cleaning and commenting
Update to properly scan the world new folders.
…ndows colors in windows 8.
…minal. Better summary in interactive mode.
…ip compression. Fix calling windows dlls in linux.
…indows. Fix missing property in AsyncDataScanner.
In fact, "poi" and "entities" can be in any dimension
Since 1.17, chunks may not have the "Entities" tag
Scan new "entities" folders (>=1.17), fix scan of "poi" folders
We display the "type" folder ("region", "poi" or "entities"), as well as the dimension folder if it's not the overworld
Fix region folder in log files
In this snapshot, the "Level" tag doesn't exist anymore
It means that for region chunks (Not entities or POI), data is now stored at the root of the chunk
Changes in the code :
- Detect chunk type with a function ("get_chunk_type()"), to avoid code duplication
- Adjustements on REGION chunks which do not have the "Level" tag
- Fix entities deletion in 1.17 entities chunks and 1.18 level chunks (Which shouldn't happen)
Important note : I use the tag "DataVersion", which I think is the best thing to do
Support for snapshot 21w43a (Minecraft 1.18)
worlds below 1.9 does not have DataVersion tag, so check it before get it it also causing wrong detection about missing entity tags
Fix errors when fixing worlds below 1.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.