Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastCS basic features #6

Merged
merged 19 commits into from
Sep 8, 2023

Conversation

MJGaughran
Copy link
Collaborator

This includes the basic features of FastCS, including:

  • Attributes and attribute parameters
  • Wrappers and Handler classes for control system interactions
  • EPICS backend, including interactive terminal

This repository works with the following branches:
Demo: https://github.com/MJGaughran/demo-fast-cs/tree/fast-cs-prototype
PVI fixes: https://github.com/epics-containers/pvi/tree/fast-cs-hacks

@MJGaughran MJGaughran self-assigned this Aug 11, 2023
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #6 (7a73434) into main (0cbc02d) will decrease coverage by 54.51%.
The diff coverage is 44.20%.

@@             Coverage Diff              @@
##              main       #6       +/-   ##
============================================
- Coverage   100.00%   45.49%   -54.51%     
============================================
  Files            2       17       +15     
  Lines           16      611      +595     
============================================
+ Hits            16      278      +262     
- Misses           0      333      +333     
Files Changed Coverage Δ
src/fastcs/backends/epics/ioc.py 26.43% <26.43%> (ø)
src/fastcs/backend.py 27.84% <27.84%> (ø)
src/fastcs/backends/epics/gui.py 36.47% <36.47%> (ø)
src/fastcs/mapping.py 39.13% <39.13%> (ø)
src/fastcs/backends/asyncio_backend.py 40.00% <40.00%> (ø)
src/fastcs/connections.py 44.73% <44.73%> (ø)
src/fastcs/wrappers.py 47.36% <47.36%> (ø)
src/fastcs/cs_methods.py 49.09% <49.09%> (ø)
src/fastcs/controller.py 51.72% <51.72%> (ø)
src/fastcs/attributes.py 56.96% <56.96%> (ø)
... and 5 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@GDYendell GDYendell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass. I think I have looked at about half of it in detail.

src/fastcs/attributes.py Show resolved Hide resolved
src/fastcs/attributes.py Outdated Show resolved Hide resolved
src/fastcs/backend.py Outdated Show resolved Hide resolved
src/fastcs/mapping.py Outdated Show resolved Hide resolved
src/fastcs/mapping.py Outdated Show resolved Hide resolved
src/fastcs/backend.py Outdated Show resolved Hide resolved
src/fastcs/backend.py Outdated Show resolved Hide resolved
src/fastcs/backend.py Outdated Show resolved Hide resolved
src/fastcs/mapping.py Outdated Show resolved Hide resolved
src/fastcs/mapping.py Outdated Show resolved Hide resolved
@MJGaughran
Copy link
Collaborator Author

Thanks for the partial review Gary. I think you've cleared up some of my thoughts, as well.

Copy link
Contributor

@GDYendell GDYendell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments / replies.

src/fastcs/attributes.py Show resolved Hide resolved
src/fastcs/backend.py Outdated Show resolved Hide resolved
src/fastcs/backends/asyncio_backend.py Show resolved Hide resolved
src/fastcs/backend.py Outdated Show resolved Hide resolved
src/fastcs/mapping.py Outdated Show resolved Hide resolved
src/fastcs/backend.py Outdated Show resolved Hide resolved
@GDYendell
Copy link
Contributor

New batch of changes look good to me 🙂

@MJGaughran MJGaughran merged commit 00f04e1 into DiamondLightSource:main Sep 8, 2023
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants