-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FastCS basic features #6
FastCS basic features #6
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6 +/- ##
============================================
- Coverage 100.00% 45.49% -54.51%
============================================
Files 2 17 +15
Lines 16 611 +595
============================================
+ Hits 16 278 +262
- Misses 0 333 +333
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass. I think I have looked at about half of it in detail.
Thanks for the partial review Gary. I think you've cleared up some of my thoughts, as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more comments / replies.
Naming for methods vs fns is getting confusing.
New batch of changes look good to me 🙂 |
This includes the basic features of FastCS, including:
This repository works with the following branches:
Demo: https://github.com/MJGaughran/demo-fast-cs/tree/fast-cs-prototype
PVI fixes: https://github.com/epics-containers/pvi/tree/fast-cs-hacks