76 pass backend options on init instead of run and provide pv name formatting options #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added options for formatting the pv names.
Also made it so that scan tasks are explicitly torn down when the backend is deleted.
evalott100
changed the title
evalott100
requested review from
GDYendell and
jsouter
and removed request for
GDYendell
|
I would like to have the pv naming in a separate PR. I am not sure it is quite right yet and maybe we should rework the way we handle combinations of controller paths and attributes entirely. I don't like that you have to call Also, I don't think we need |
evalott100
deleted the
76-pass-backend-options-on-init-instead-of-run
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #76
Reopening because #77 was struggling with fetching a dropped commit.