Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redirect_output_to: flush(), fsync(), and close before resetting stdout and stderr #75

Merged
merged 2 commits into from
Nov 6, 2024
Merged

redirect_output_to: flush(), fsync(), and close before resetting stdout and stderr #75

merged 2 commits into from
Nov 6, 2024

Conversation

thomasmfish
Copy link
Contributor

Possible fix for #64

@thomasmfish thomasmfish added the bug Something isn't working label Oct 16, 2024
@thomasmfish thomasmfish self-assigned this Oct 16, 2024
@thomasmfish thomasmfish mentioned this pull request Oct 16, 2024
Open
PeterC-DLS
PeterC-DLS approved these changes Oct 17, 2024
View reviewed changes
Copy link

@PeterC-DLS PeterC-DLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasmfish thomasmfish force-pushed the potential-log-truncation-fix branch from 7ff98c7 to 59241fb Compare October 18, 2024 11:25
@thomasmfish thomasmfish merged commit 74c069d into main Nov 6, 2024
1 check passed
@thomasmfish thomasmfish deleted the potential-log-truncation-fix branch November 6, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterC-DLS PeterC-DLS PeterC-DLS approved these changes

Assignees

@thomasmfish thomasmfish

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasmfish @PeterC-DLS