Improve messaging to user #76
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 16, 2024 17:23
…hannels have processed
…raising exceptions
…alse`, raising a `UndefinedValueError` if a channel is empty
thomasmfish
added a commit
that referenced
this pull request
Oct 17, 2024
…#79) With the better exception handling from #76, it is now more likely that a combined log file will not be created because an exception is raised before the end of the loop. It makes sense to created a combined log file regardless of success, so long as there are per-channel log files to combine. This moves log file creation from `_processing_files_to_output` (now renamed to `_reconstructions_to_output`, since it's now just doing the reconstructions) into a new `finally` clause around the actual reconstruction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various changes that allow better messages: