Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select controller by module name rather than adapter name #45

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

ajgdls
Copy link
Contributor

@ajgdls ajgdls commented Oct 21, 2024

Adapters can be given any name, but the module name is fixed by the adapter class itself.
It is better to select the fastcs controller according to the module name rather then the assigned adapter name.

Fixes #29
Fixes #23

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.

Project coverage is 85.30%. Comparing base (ca62554) to head (83941d3).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/fastcs_odin/odin_controller.py 54.54% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
+ Coverage   82.92%   85.30%   +2.38%     
==========================================
  Files           9        9              
  Lines         404      415      +11     
==========================================
+ Hits          335      354      +19     
+ Misses         69       61       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsouter
Copy link
Contributor

jsouter commented Oct 21, 2024

edit: ignore me, I needed to update my dev/local/odin_server.cfg!

Copy link
Contributor

@GDYendell GDYendell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Given #22 already exists I don't mind the missing lines that codecov is complaining about here.

@ajgdls ajgdls merged commit 918524e into main Oct 22, 2024
18 of 19 checks passed
@ajgdls ajgdls deleted the controller-select branch October 22, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants