Check a valid service name has been provided #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove some redundant parameters. - Construct the known_services help string separately (we'll use it again). - Exit early if no service has been specified, instead of opening a frontend with no service and quietly twiddling our thumbs. No attempt is made here to migrate to argparse.ArgumentParser instead of the deprecated optparse.OptionParser, though the 'required' argument of 'ArgumentParser.add_argument' would obviate the need for separately checking whether the '--service' option has been invoked.
At present, a user can grow accustomed to lazily providing lower-case service names when invoking 'workflows.service' from the command line. This works fine until you encounter the following situation: - Known services include "DLSISPyB" and "DLSISPyBPIA"; - user specifies '-s dlsispyb', expecting this to be interpreted as 'DLSISPyB', or else expecting an error; - not finding a perfect match, the current logic checks whether any known service names, rendered in lower case, start with 'dlsispyb', finds two such matches; - rather than selecting either of these two matches, the program quietly continues to open a frontend and doesn't start any service; - user sees so warning or error, program twiddles its thumbs until terminated. New logic: 1. Check for perfect match; 2. Failing that, check for case-insensitive match; 3. Failing that, check for case-sensitive partial matches. If ambiguous, exit with error. 4. Failing that, repeat 3 but now case-insensitive. 5. If still no matches, exit with error.
|
Was there anything else that needed to happen here for this to be worth merging? |
|
This looks a definite improvement, and seems to work as-is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, a user can grow accustomed to lazily providing lower-case service names when invoking
workflows.servicefrom the command line. This works fine until you encounter the following situation:DLSISPyBandDLSISPyBPIA;-s dlsispyb, expecting this to be interpreted asDLSISPyB, or else expecting an error;dlsispyb, finds two such matches;New logic: