-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System tests #120
base: main
Are you sure you want to change the base?
System tests #120
Conversation
I would suggest waiting with this until after RabbitMQ is deployed and support for ActiveMQ is deprecated/removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having said that, I'm not hostile to adding this if you're fine with it being completely rewritten later.
I would suggest though to rename the command to zocalo.run_system_tests
to match dlstbx and give a stronger sense of what this is about.
Note: The original agreement was that this wouldn't go into the zocalo package, but into zocalo-dls. |
I think its useful outside of dls? I already have this running like you on a 30 min basis to test various services. I keep the esrf specific system tests in an esrf repo (i.e. we have our own file watcher), but i think the general code is useful to all sites? |
md converted to rst, cli tool renamed |
This pull request introduces 1 alert when merging c928650 into 702d3fc - view on LGTM.com new alerts:
|
Tests are now found via entry points. Also added a pytest style -k to filter tests.
Probably need a config option to disable certain tests, for example once switched to rabbitmq we won't want to run the activemq test.